On 3/14/19 8:19 AM, Samuel Thibault wrote: > Hello, > > Should this go through my tree, or perhaps it can be directly pushed to > master by Peter since it's no-code-only-copyright changes?
I think this definitely qualifies as 4.0 material. However, while it does not affect compilation, it DOES have legal ramification; I'd feel a lot better about having R-b on every patch, that we had a second (or third) set of eyes double-check that the right SPDX identifier is used everywhere. I don't have time to complete that audit today, so I'm hoping someone else will step in and help. (This is complicated by the fact that the email alone does not show the existing license; it may be easier to apply the patch locally, and then use git diff tuned to give a 20 or 30 line context instead of the usual default of 3, to make it easier to check for SPDX match to existing licenses on each file being modified) And thanks, Marc-André, for bearing with my nit-pickiness on this series. I hope you agree with my insistence that we get this right, so that we don't expose ourselves to legal troubles down the road. I like the split in this series, even if I have not had time to finish an audit that the changes in 3-6 are correct. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
