On 30/04/2019 17:43, Richard Henderson wrote: > On 4/28/19 7:38 AM, Mark Cave-Ayland wrote: >> Rather than perform the VSR register decoding within the helper itself, >> introduce a new GEN_VSX_HELPER_X1 macro which performs the decode based >> upon xB at translation time. >> >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> >> --- >> target/ppc/fpu_helper.c | 6 ++---- >> target/ppc/helper.h | 8 ++++---- >> target/ppc/translate/vsx-impl.inc.c | 24 ++++++++++++++++++++---- >> 3 files changed, 26 insertions(+), 12 deletions(-) > > Similarly wrt VSX_TSQRT.
Yes, and also the other helper touched here: helper_xststdcsp(). I think the comment here is basically the same as for GEN_VSX_HELPER_X2_AB. ATB, Mark.