Patchew URL: https://patchew.org/QEMU/20190619221933.1981-1-laur...@vivier.eu/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v8 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine Type: series Message-id: 20190619221933.1981-1-laur...@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190619221933.1981-1-laur...@vivier.eu -> patchew/20190619221933.1981-1-laur...@vivier.eu Switched to a new branch 'test' d87fb4249f hw/m68k: define Macintosh Quadra 800 65f79545a0 hw/m68k: add a dummy SWIM floppy controller 7c656d0722 hw/m68k: add Nubus support for macfb video card be7b2607e8 hw/m68k: add Nubus support 55b5d6c451 hw/m68k: add macfb video card 8194119b9c hw/m68k: implement ADB bus support for via 9f35eabcdf hw/m68k: add via support 996fa6f5f1 dp8393x: manage big endian bus 1c2a722f31 esp: add pseudo-DMA as used by Macintosh 0bbfb84e62 escc: introduce a selector for the register bit === OUTPUT BEGIN === 1/10 Checking commit 0bbfb84e625c (escc: introduce a selector for the register bit) 2/10 Checking commit 1c2a722f314f (esp: add pseudo-DMA as used by Macintosh) 3/10 Checking commit 996fa6f5f117 (dp8393x: manage big endian bus) 4/10 Checking commit 9f35eabcdf9a (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #92: FILE: hw/misc/mac_via.c:49: +#define VIA1A_vSccWrReq 0x80 /* SCC write. (input) WARNING: Block comments use a leading /* on a separate line #99: FILE: hw/misc/mac_via.c:56: +#define VIA1A_vRev8 0x40 /* Revision 8 board ??? WARNING: Block comments use a leading /* on a separate line #109: FILE: hw/misc/mac_via.c:66: +#define VIA1A_vHeadSel 0x20 /* Head select for IWM. WARNING: Block comments use a leading /* on a separate line #114: FILE: hw/misc/mac_via.c:71: +#define VIA1A_vOverlay 0x10 /* [Macintosh Family] On SE/30,II,IIx,IIcx WARNING: Block comments use a leading /* on a separate line #128: FILE: hw/misc/mac_via.c:85: +#define VIA1A_vSync 0x08 /* [CHRP] Sync Modem: modem clock select: WARNING: Block comments use a leading /* on a separate line #136: FILE: hw/misc/mac_via.c:93: +/* Macintosh Family Hardware sez: bits 0-2 of VIA1A are volume control WARNING: Block comments use a leading /* on a separate line #151: FILE: hw/misc/mac_via.c:108: +/* Info on VIA1B is from Macintosh Family Hardware & MkLinux. WARNING: Block comments use a trailing */ on a separate line #152: FILE: hw/misc/mac_via.c:109: + * CHRP offers no info. */ WARNING: Block comments use a leading /* on a separate line #153: FILE: hw/misc/mac_via.c:110: +#define VIA1B_vSound 0x80 /* Sound enable (for compatibility with WARNING: Block comments use a trailing */ on a separate line #156: FILE: hw/misc/mac_via.c:113: + * 0=error, 1=OK. */ WARNING: Block comments use a leading /* on a separate line #157: FILE: hw/misc/mac_via.c:114: +#define VIA1B_vMystery 0x40 /* On IIci, parity enable. 0=enabled,1=disabled WARNING: Block comments use a trailing */ on a separate line #160: FILE: hw/misc/mac_via.c:117: + * as a slot $E interrupt. */ WARNING: Block comments use a leading /* on a separate line #187: FILE: hw/misc/mac_via.c:144: +/* RAM size bits decoded as follows: WARNING: Block comments use a leading /* on a separate line #199: FILE: hw/misc/mac_via.c:156: +#define VIA2B_vVBL 0x80 /* VBL output to VIA1 (60.15Hz) driven by WARNING: Block comments use a trailing */ on a separate line #202: FILE: hw/misc/mac_via.c:159: + * [MkLinux] RBV_PARODD: 1=odd,0=even. */ WARNING: Block comments use a leading /* on a separate line #203: FILE: hw/misc/mac_via.c:160: +#define VIA2B_vSndJck 0x40 /* External sound jack status. WARNING: Block comments use a trailing */ on a separate line #204: FILE: hw/misc/mac_via.c:161: + * 0=plug is inserted. On SE/30, always 0 */ WARNING: Block comments use a leading /* on a separate line #207: FILE: hw/misc/mac_via.c:164: +#define VIA2B_vMode32 0x08 /* 24/32bit switch - doubles as cache flush WARNING: Block comments use a leading /* on a separate line #215: FILE: hw/misc/mac_via.c:172: +#define VIA2B_vPower 0x04 /* Power off, 0=shut off power. WARNING: Block comments use a leading /* on a separate line #218: FILE: hw/misc/mac_via.c:175: +#define VIA2B_vBusLk 0x02 /* Lock NuBus transactions, 0=locked. WARNING: Block comments use a leading /* on a separate line #221: FILE: hw/misc/mac_via.c:178: +#define VIA2B_vCDis 0x01 /* Cache control. On IIci, 1=disable cache card WARNING: Block comments use a leading /* on a separate line #235: FILE: hw/misc/mac_via.c:192: +/* Apple sez: http://developer.apple.com/technotes/ov/ov_04.html WARNING: Block comments use a leading /* on a separate line #264: FILE: hw/misc/mac_via.c:221: + /* CHRP sez never ever to *write* this. WARNING: Block comments use a leading /* on a separate line #280: FILE: hw/misc/mac_via.c:237: +/* Apple Macintosh Family Hardware Refenece ERROR: space prohibited after that '&&' (ctx:WxW) #362: FILE: hw/misc/mac_via.c:319: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 25 warnings, 789 lines checked Patch 4/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/10 Checking commit 8194119b9c1c (hw/m68k: implement ADB bus support for via) 6/10 Checking commit 55b5d6c451cd (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 502 lines checked Patch 6/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/10 Checking commit be7b2607e8a2 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 7/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/10 Checking commit 7c656d0722bd (hw/m68k: add Nubus support for macfb video card) 9/10 Checking commit 65f79545a0f9 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #233: FILE: hw/block/swim.c:192: + /* rerror/werror aren't supported by fdc and therefore not even registered WARNING: Block comments use a trailing */ on a separate line #235: FILE: hw/block/swim.c:194: + * blkconf_apply_backend_options(). */ WARNING: Block comments use a leading /* on a separate line #245: FILE: hw/block/swim.c:204: + /* 'enospc' is the default for -drive, 'report' is what blk_new() gives us WARNING: Block comments use a trailing */ on a separate line #246: FILE: hw/block/swim.c:205: + * for empty drives. */ total: 0 errors, 5 warnings, 504 lines checked Patch 9/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/10 Checking commit d87fb4249f5e (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #95: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #289: FILE: hw/m68k/q800.c:70: +/* the video base, whereas it a Nubus address, WARNING: Block comments use a leading /* on a separate line #409: FILE: hw/m68k/q800.c:190: + /* MacSonic driver needs an Apple MAC address total: 0 errors, 3 warnings, 533 lines checked Patch 10/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190619221933.1981-1-laur...@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
