On Tue, May 03, 2011 at 03:08:43PM +0200, Paolo Bonzini wrote: > On 05/03/2011 02:06 PM, Christoph Hellwig wrote: >> + case IDE_DMA_TRIM: >> + m->aiocb = dma_bdrv_io(s->bs,&s->sg, sector_num, >> + ide_issue_trim,, pmac_ide_transfer_cb, s, 1); >> + break; > > Not compile-tested?
pmac emulation indeed wasn't in my usual compile setup. Removing the comma makes pmac compile, but I still can't finish a "full" qemu build: hch@rocky:~/work/qemu$ make CC arm-softmmu/gdbstub-xml.o cc1: warnings being treated as errors In file included from ../qemu-common.h:5:0, from gdbstub-xml.c:2: ../config-host.h:2:0: error: "CONFIG_QEMU_PREFIX" redefined config.h:2:0: note: this is the location of the previous definition In file included from gdbstub-xml.c:140:0: config.h:2:0: error: "CONFIG_QEMU_PREFIX" redefined ../config-host.h:2:0: note: this is the location of the previous definition make[1]: *** [gdbstub-xml.o] Error 1 make: *** [subdir-arm-softmmu] Error 2