On 7/4/19 12:25 PM, Philippe Mathieu-Daudé wrote:
>
>
> On 7/4/19 12:21 PM, Alex Bennée wrote:
>>
>> Richard Henderson <richard.hender...@linaro.org> writes:
>>
>>> On 7/3/19 5:52 PM, Alex Bennée wrote:
>>>> +static inline void gen_thumb_bkpt(DisasContext *s, int imm8)
>>>> +{
>>>> + if (arm_dc_feature(s, ARM_FEATURE_M) &&
>>>> + semihosting_enabled() &&
>>>> +#ifndef CONFIG_USER_ONLY
>>>> + s->current_el != 0 &&
>>>> +#endif
>>>> + (imm8 == 0xab)) {
>>>
>>> Extra parenthesis.
>>
>> The wrapping on imm8 == 0xab? Do you want that cleaned up on the other
>> patches as well?
>
> I understood this comment for "(s->current_el != 0) &&"
>
No, I meant imm8 == 0xab. And, sure, cleaning the other patches would be good.
r~
