On 7/30/19 1:37 PM, Paolo Bonzini wrote: > On 30/07/19 11:54, Philippe Mathieu-Daudé wrote: >> Hi John, >> >> On 7/30/19 12:36 AM, John Snow wrote: >>> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394. >>> >>> It's not correct to just ignore an error code in a callback; we need to >>> handle that error and possible report failure to the guest so that they >>> don't wait indefinitely for an operation that will now never finish. >> >> Is this 4.1 material? It looks so. > > Perhaps could have been last week, but now I suggest Cc qemu-stable and > delaying it to 4.2.
I was wondering because Kevin was preparing a block@ pull request. Anyway this seems fair because the reverted commit is dated from 2014. Thanks, Phil.
