On 7/30/19 5:54 AM, Philippe Mathieu-Daudé wrote:
> Hi John,
> 
> On 7/30/19 12:36 AM, John Snow wrote:
>> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394.
>>
>> It's not correct to just ignore an error code in a callback; we need to
>> handle that error and possible report failure to the guest so that they
>> don't wait indefinitely for an operation that will now never finish.
> 
> Is this 4.1 material? It looks so.
> 

Nah. This reverts a commit from 2014. I have no valid argument for why
this is critical :)

Thanks for checking!

--js

Reply via email to