On Tue, Jul 30, 2019 at 11:07 PM Eduardo Habkost <ehabk...@redhat.com> wrote:
> Sometimes we use the 'struct' keyword to help us reduce > dependencies between header files. Document that practice. > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > I wonder if this is too terse? Should we give examples? > --- > I am inclined to have the judgement very similar to Eric's - it seems to me the change is fine as is, so: Reviewed-by: Aleksandar Markovic <amarko...@wavecomp.com> > HACKING | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/HACKING b/HACKING > index 0fc3e0fc04..112685bdaf 100644 > --- a/HACKING > +++ b/HACKING > @@ -101,6 +101,8 @@ it points to, or it is aliased to another pointer that > is. > > 2.3. Typedefs > Typedefs are used to eliminate the redundant 'struct' keyword. > +However, the 'struct' keyword may be sometimes used in header > +files to avoid unnecessary dependencies between headers. > > 2.4. Reserved namespaces in C and POSIX > Underscore capital, double underscore, and underscore 't' suffixes should > be > -- > 2.21.0 > >