Re: [Qemu-devel] [PATCH v2 06/28] s390x/tcg: MVC: Use is_destructive_overlap()

[Richard Henderson]

On 9/6/19 3:57 AM, David Hildenbrand wrote:
>      if (dest == src + 1) {
>          fast_memset(env, dest, cpu_ldub_data_ra(env, src, ra), l, ra);
> -    } else if (dest < src || src + l <= dest) {
> +    } else if (!is_destructive_overlap(env, dest, src, l)) {
>          fast_memmove(env, dest, src, l, ra);
>      } else {
>          for (i = 0; i < l; i++) {

I suppose, though last time I checked fast_memmove didn't support wrapping.

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~