Re: [Qemu-devel] [PATCH v2 11/28] s390x/tcg: MVCS/MVCP: Properly wrap the length

[Richard Henderson]

On 9/6/19 3:57 AM, David Hildenbrand wrote:
> +    l = wrap_length(env, l);
>      if (l > 256) {
>          /* max 256 */
>          l = 256;
>          cc = 3;
> +    } else if (!l) {
> +        return cc;
>      }

Um, wrap_length only takes 31 bits.
These insns take 32 bits in 24/31-bit modes.


r~