Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190911155125.11932-1-eric.au...@redhat.com -> patchew/20190911155125.11932-1-eric.au...@redhat.com - [tag update] patchew/20190912060701.4642-1-ys...@users.sourceforge.jp -> patchew/20190912060701.4642-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 8840cbe qapi/machine.json: Add RX cpu. 4771d28 BootLinuxConsoleTest: Test the RX-Virt machine 0ec329e Add rx-softmmu bbc35e0 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 1101341 hw/rx: Honor -accel qtest a74f685 hw/rx: RX Target hardware definition d8a6c3f hw/char: RX62N serial communication interface (SCI) 19db804 hw/timer: RX62N internal timer modules d62c0fc hw/intc: RX62N interrupt controller (ICUa) fb0a977 target/rx: Dump bytes for each insn during disassembly 5f7434e target/rx: Collect all bytes during disassembly 85a2cc5 target/rx: Emit all disassembly in one prt() 522142f target/rx: Use prt_ldmi for XCHG_mr disassembly 1def58b target/rx: Replace operand with prt_ldmi in disassembler c655e3d target/rx: Disassemble rx_index_addr into a string 96bdcb6 target/rx: RX disassembler 64e57e5 target/rx: CPU definition de36389 target/rx: TCG helper 0663825 target/rx: TCG translation 36d9ad4 hw/registerfields.h: Add 8bit and 16bit register macros f1d9a7f qemu/bitops.h: Add extract8 and extract16 a4c45e2 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit a4c45e218ea4 (MAINTAINERS: Add RX) 2/22 Checking commit f1d9a7fda4d6 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 36d9ad4d18a6 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 066382540c53 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit de3638959b10 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 64e57e51cdfe (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 96bdcb65077f (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit c655e3d74d62 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 1def58b9354e (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 522142f319b1 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 85a2cc54ba82 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 5f7434eb5757 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit fb0a97747b43 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit d62c0fcfec86 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 19db80403fae (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit d8a6c3f3d21b (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit a74f68504808 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 110134180d8b (hw/rx: Honor -accel qtest) 19/22 Checking commit bbc35e031774 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 0ec329eeeee1 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 4771d283f8a5 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 8840cbe6b3ab (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com