Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190912060701.4642-1-ys...@users.sourceforge.jp -> patchew/20190912060701.4642-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 4839961 qapi/machine.json: Add RX cpu. ee1a34c BootLinuxConsoleTest: Test the RX-Virt machine 4bce111 Add rx-softmmu dd0ced9 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core c96b527 hw/rx: Honor -accel qtest edda463 hw/rx: RX Target hardware definition c0a3cae hw/char: RX62N serial communication interface (SCI) fc2fa4e hw/timer: RX62N internal timer modules df2c149 hw/intc: RX62N interrupt controller (ICUa) c3fa177 target/rx: Dump bytes for each insn during disassembly 9fee305 target/rx: Collect all bytes during disassembly 2ce3519 target/rx: Emit all disassembly in one prt() 60ad535 target/rx: Use prt_ldmi for XCHG_mr disassembly 4f15796 target/rx: Replace operand with prt_ldmi in disassembler 54f46ef target/rx: Disassemble rx_index_addr into a string b0f939a target/rx: RX disassembler 3343ef5 target/rx: CPU definition 20e5daa target/rx: TCG helper d345ff0 target/rx: TCG translation a6c73ed hw/registerfields.h: Add 8bit and 16bit register macros 624d286 qemu/bitops.h: Add extract8 and extract16 7a7544c MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 7a7544c80606 (MAINTAINERS: Add RX) 2/22 Checking commit 624d286dbc3b (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit a6c73edab979 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit d345ff0914d4 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 20e5daaba751 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 3343ef5d08c6 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit b0f939a431d1 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 54f46ef1d86a (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 4f157967ac8c (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 60ad5358dfcf (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 2ce3519386d5 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 9fee3055f6b2 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit c3fa177cd274 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit df2c14900c44 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit fc2fa4e6ee7a (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit c0a3cae6bf5a (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit edda463ad0aa (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit c96b527d5cc1 (hw/rx: Honor -accel qtest) 19/22 Checking commit dd0ced9a2709 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 4bce11113551 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit ee1a34c691b4 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 4839961c0c48 (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com