error_append_hint will not work, if errp == &fatal_error, as program
will exit before error_append_hint call. Fix this by use of special
macro ERRP_FUNCTION_BEGIN.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
CC: John Snow <js...@redhat.com>
CC: Kevin Wolf <kw...@redhat.com>
CC: Max Reitz <mre...@redhat.com>
CC: Fam Zheng <f...@euphon.net>
CC: Jeff Cody <codypr...@gmail.com>
CC: "Marc-André Lureau" <marcandre.lur...@redhat.com>
CC: Paolo Bonzini <pbonz...@redhat.com>
CC: Greg Kurz <gr...@kaod.org>
CC: Subbaraya Sundeep <sundeep.l...@gmail.com>
CC: Peter Maydell <peter.mayd...@linaro.org>
CC: Paul Burton <pbur...@wavecomp.com>
CC: Aleksandar Rikalo <arik...@wavecomp.com>
CC: "Michael S. Tsirkin" <m...@redhat.com>
CC: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
CC: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
CC: David Gibson <da...@gibson.dropbear.id.au>
CC: Yuval Shaia <yuval.sh...@oracle.com>
CC: Cornelia Huck <coh...@redhat.com>
CC: Eric Farman <far...@linux.ibm.com>
CC: Richard Henderson <r...@twiddle.net>
CC: David Hildenbrand <da...@redhat.com>
CC: Halil Pasic <pa...@linux.ibm.com>
CC: Christian Borntraeger <borntrae...@de.ibm.com>
CC: Gerd Hoffmann <kra...@redhat.com>
CC: Alex Williamson <alex.william...@redhat.com>
CC: Markus Armbruster <arm...@redhat.com>
CC: Michael Roth <mdr...@linux.vnet.ibm.com>
CC: Juan Quintela <quint...@redhat.com>
CC: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
CC: Eric Blake <ebl...@redhat.com>
CC: Jason Wang <jasow...@redhat.com>
CC: "Daniel P. Berrangé" <berra...@redhat.com>
CC: Eduardo Habkost <ehabk...@redhat.com>
CC: qemu-bl...@nongnu.org
CC: qemu-devel@nongnu.org
CC: integrat...@gluster.org
CC: qemu-...@nongnu.org
CC: qemu-...@nongnu.org
CC: qemu-s3...@nongnu.org
.../fix-error_append_hint-usage.cocci | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 scripts/coccinelle/fix-error_append_hint-usage.cocci
diff --git a/scripts/coccinelle/fix-error_append_hint-usage.cocci
b/scripts/coccinelle/fix-error_append_hint-usage.cocci
new file mode 100644
index 0000000000..327fe6098c
--- /dev/null
+++ b/scripts/coccinelle/fix-error_append_hint-usage.cocci
@@ -0,0 +1,25 @@
+@rule0@
+// Add invocation to errp-functions
+identifier fn;
+@@
+
+ fn(..., Error **errp, ...)
+ {
++ ERRP_FUNCTION_BEGIN();
+ <+...
+ error_append_hint(errp, ...);
+ ...+>
+ }
+
+@@
+// Drop doubled invocation
+identifier rule0.fn;
+@@
+
+ fn(...)
+{
+ ERRP_FUNCTION_BEGIN();
+- ERRP_FUNCTION_BEGIN();
+ ...
+}
+
--
2.21.0
