On 10/04/19 00:54, Philippe Mathieu-Daudé wrote: > Since a QFWCFG object is not tied to a particular test, we can > call *_fw_cfg_init() once before creating QTests and use the same > for all the tests, then release the object with g_free() once all > the tests are run. > > Refactor the qfw_cfg* API to take QTestState as argument. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > tests/boot-order-test.c | 12 ++++---- > tests/fw_cfg-test.c | 49 ++++++++++++++++---------------- > tests/libqos/fw_cfg.c | 61 ++++++++++++++++++++-------------------- > tests/libqos/fw_cfg.h | 30 +++++++++----------- > tests/libqos/malloc-pc.c | 4 +-- > 5 files changed, 77 insertions(+), 79 deletions(-)
Not much fun to review. :) Reviewed-by: Laszlo Ersek <ler...@redhat.com>