On 10/08/19 15:35, Philippe Mathieu-Daudé wrote: > On 10/8/19 12:52 PM, Laszlo Ersek wrote: >> The enable_compat_apic_id_mode() function definition was removed earlier; > > "in 457cfcccdd1"
Thanks. I'll add that to the commit message if I need to post a v2. > >> there are no callers left. Remove the function declaration too. >> >> Cc: Eduardo Habkost <ehabk...@redhat.com> >> Cc: Igor Mammedov <imamm...@redhat.com> >> Cc: Paolo Bonzini <pbonz...@redhat.com> >> Cc: Richard Henderson <r...@twiddle.net> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 >> Signed-off-by: Laszlo Ersek <ler...@redhat.com> >> --- >> target/i386/cpu.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/target/i386/cpu.h b/target/i386/cpu.h >> index eaa5395aa539..c9ab1a367939 100644 >> --- a/target/i386/cpu.h >> +++ b/target/i386/cpu.h >> @@ -2126,8 +2126,6 @@ void x86_cpu_set_default_version(X86CPUVersion >> version); >> /* Return name of 32-bit register, from a R_* constant */ >> const char *get_register_name_32(unsigned int reg); >> -void enable_compat_apic_id_mode(void); >> - >> #define APIC_DEFAULT_ADDRESS 0xfee00000 >> #define APIC_SPACE_SIZE 0x100000 >> > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Cheers! Laszlo
