On Fri, 4 Oct 2019 12:51:01 +0200 David Hildenbrand <da...@redhat.com> wrote:
> Let's use consitent names for the region/section/page table entries and Can you still fixup s/consitent/consistent/ before picking up? :) > for the macros to extract relevant parts from virtual address. Make them > match the definitions in the PoP - e.g., how the relevant bits are actually > called. > > Introduce defines for all bits declared in the PoP. This will come in > handy in follow-up patches. > > Add a note where additional information about s390x and the used > definitions can be found. > > Acked-by: Richard Henderson <richard.hender...@linaro.org> > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > target/s390x/cpu.h | 78 +++++++++++++++++++++++++++++---------- > target/s390x/mem_helper.c | 12 +++--- > target/s390x/mmu_helper.c | 37 ++++++++++--------- > 3 files changed, 84 insertions(+), 43 deletions(-)
