On Mon, 7 Oct 2019 at 18:06, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > The BCM2838 has many more peripherals than his little brother, > the BCM2837. With the raspi4, the Linux kernel takes more steps > to configure the various MUXed devices. At some point it started > to bug me, so I plan to add a dummy simple BCM2835_SPI block. > It is cleaner to add it as a separate device than mixed with the > AUX block. As a first step, split the UART block out. > > Since this part is self-contained and my raspi4 branch is getting > too big, I'm sending it as a single series.
If you squash patches 1 and 2 together and avoid doing things like renaming all the register offset constant names (or, for stuff like fixing up comment syntax and checkpatch nits, do them in a preparatory patch), then it becomes somewhat easier to review, because then you can use git diff --color-moved and can see easily that code has only been moved to the other file without any accidental extra changes. thanks -- PMM