On Fri, 18 Oct 2019 at 16:43, Marc-André Lureau <marcandre.lur...@redhat.com> wrote: > > Since clock are not QOM objects, replace PROP_PTR of clocks with > setters methods. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> -/* Using qdev pointer properties for the clocks is not ideal. > - * qdev should support a generic means of defining a 'port' with > - * an arbitrary interface for connecting two devices. Then we > - * could reframe the omap clock API in terms of clock ports, > - * and get some type safety. For now the best qdev provides is > - * passing an arbitrary pointer. > - * (It's not possible to pass in the string which is the clock > - * name, because this device does not have the necessary information > - * (ie the struct omap_mpu_state_s*) to do the clockname to pointer > - * translation.) > - */ Ah, here's what's effectively a todo comment that you could repurpose/adapt/move. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
