We should make sure drive.lchs is zeroed out for the following devices: git grep "drive_s drive"
src/hw/ata.h: struct drive_s drive; src/hw/esp-scsi.c: struct drive_s drive; src/hw/lsi-scsi.c: struct drive_s drive; src/hw/megasas.c: struct drive_s drive; src/hw/mpt-scsi.c: struct drive_s drive; src/hw/nvme-int.h: struct drive_s drive; src/hw/pvscsi.c: struct drive_s drive; src/hw/sdcard.c: struct drive_s drive; src/hw/usb-msc.c: struct drive_s drive; src/hw/usb-uas.c: struct drive_s drive; src/hw/virtio-blk.c: struct drive_s drive; src/hw/virtio-scsi.c: struct drive_s drive; Sam On Wed, Nov 13, 2019 at 5:03 PM Sam Eiderman <sam...@google.com> wrote: > > Hi, > > Does this fix a bug that actually happened? > > I just noticed that in my lchs patches I assumed that lchs struct is > zeroed out in all devices (not only ahci): > > 9caa19be0e53 (geometry: Apply LCHS values for boot devices) > > Seems like this is not the case but why only ahci is affected? > > The list of devices is at least: > > * ata > * ahci > * scsi > * esp > * lsi > * megasas > * mpt > * pvscsi > * virtio > * virtio-blk > > As specified in the commit message. > > Also Gerd it seems that my lchs patches were not committed in the > latest submitted version (v4)!!! > The ABI of the fw config key is completely broken. > > > On Wed, Nov 13, 2019 at 4:02 PM Gerd Hoffmann <kra...@redhat.com> wrote: > > > > On Wed, Nov 13, 2019 at 10:35:03AM +0100, Laszlo Ersek wrote: > > > On 11/13/19 10:18, Gerd Hoffmann wrote: > > > > Specifically port->driver.lchs needs clearing, otherwise seabios will > > > > > > s/driver/drive/ > > > > > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > > > > Typo fixed & pushed. > > > > thanks, > > Gerd > > _______________________________________________ > > SeaBIOS mailing list -- seab...@seabios.org > > To unsubscribe send an email to seabios-le...@seabios.org
