Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

[Philippe Mathieu-Daudé]

Hi Sam,

On 11/13/19 4:03 PM, Sam Eiderman wrote:

Hi,

Does this fix a bug that actually happened?

I just noticed that in my lchs patches I assumed that lchs struct is
zeroed out in all devices (not only ahci):

9caa19be0e53 (geometry: Apply LCHS values for boot devices)

Seems like this is not the case but why only ahci is affected?

The list of devices is at least:

         * ata
         * ahci
         * scsi
             * esp
             * lsi
             * megasas
             * mpt
             * pvscsi
             * virtio
         * virtio-blk

As specified in the commit message.

Also Gerd it seems that my lchs patches were not committed in the
latest submitted version (v4)!!!
The ABI of the fw config key is completely broken.

What do you mean? Can you be more specific?