On 03/12/19 11:34, Greg Kurz wrote: > On Fri, 29 Nov 2019 13:59:37 +0100 > Greg Kurz <gr...@kaod.org> wrote: > >> On Fri, 29 Nov 2019 13:49:20 +0100 >> Paolo Bonzini <pbonz...@redhat.com> wrote: >> >>> On 29/11/19 13:32, Greg Kurz wrote: >>>> Nice. :) >>>> >>>> Reviewed-by: Greg Kurz <gr...@kaod.org> >>>> >>>> Paolo, >>>> >>>> I can take this through my 9p tree if you want. Otherwise, >>>> >>>> Acked-by: Greg Kurz <gr...@kaod.org> >>> >>> Yes, please do it since it's self-contained. You'd probably also test >>> it better than me. :) >>> >>> Paolo >>> >> >> Ok I'll just do that then. >> > > And it happens to be missing an extra-change in Makefile :) > > -fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap > +fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap-ng
The new line is not needed, -lcap-ng should already be in LIBS via LIBS+=-lz $(LIBS_TOOLS) However, removing -lcap is certainly a good idea. :) Paolo
