Paolo Bonzini <pbonz...@redhat.com> wrote: > On 12/12/19 23:20, Juan Quintela wrote: >> Hi >> >> This series simplify test_migrate_start() in two ways: >> - simplify the command line creation, so everything that is common between >> architectures don't have to be repeated (DRY). >> Note that this bit remove lines of code. >> - test_migrate_start() has two bools and two strings as arguments, it is very >> difficult to remmeber which is which and meaning. And it is even worse to >> add new parameters. Just pass them through one struct. >> >> Please, review. >> >> Juan Quintela (10): >> migration-test: Create cmd_soure and cmd_target >> migration-test: Move hide_stderr to common commandline >> migration-test: Move -machine to common commandline >> migration-test: Move memory size to common commandline >> migration-test: Move shmem handling to common commandline >> migration-test: Move -name handling to common commandline >> migration-test: Move -serial handling to common commandline >> migration-test: Move -incomming handling to common commandline >> migration-test: Rename cmd_src/dst to arch_source/arch_target >> migration-test: Use a struct for test_migrate_start parameters >> >> tests/migration-test.c | 265 +++++++++++++++++++++++------------------ >> 1 file changed, 147 insertions(+), 118 deletions(-) >> > > I have picked up this series and rebased the -accel changes on top.
Thanks. about the accel and the machine type, .... it feel so weird that we only need to add a machine type for aarch64. Later, Juan.
