Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:
hw/timer/aspeed_timer.c: In function ‘aspeed_timer_set_value’:
hw/timer/aspeed_timer.c:283:24: error: this statement may fall through
[-Werror=implicit-fallthrough=]
283 | if (old_reload || !t->reload) {
| ~~~~~~~~~~~^~~~~~~~~~~~~
hw/timer/aspeed_timer.c:287:5: note: here
287 | case TIMER_REG_STATUS:
| ^~~~
cc1: all warnings being treated as errors
Add the missing fall through comment.
Fixes: 1403f364472
Reviewed-by: Cédric Le Goater <c...@kaod.org>
Reviewed-by: Aleksandar Markovic <amarko...@wavecomp.com>
Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
---
Cc: "Cédric Le Goater" <c...@kaod.org>
Cc: Peter Maydell <peter.mayd...@linaro.org>
Cc: Andrew Jeffery <and...@aj.id.au>
Cc: Joel Stanley <j...@jms.id.au>
Cc: qemu-...@nongnu.org
---
hw/timer/aspeed_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c
index a8c38cc118..c91f18415c 100644
--- a/hw/timer/aspeed_timer.c
+++ b/hw/timer/aspeed_timer.c
@@ -283,7 +283,7 @@ static void aspeed_timer_set_value(AspeedTimerCtrlState *s,
int timer, int reg,
if (old_reload || !t->reload) {
break;
}
-
+ /* fall through to re-enable */
case TIMER_REG_STATUS:
if (timer_enabled(t)) {
uint64_t now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
--
2.21.0
