Re: [PATCH] audio/oss: fix buffer pos calculation

[Philippe Mathieu-Daudé]

On 1/20/20 11:18 AM, Gerd Hoffmann wrote:

Fixes: 3ba4066d085f ("ossaudio: port to the new audio backend api")
Reported-by: ziming zhang <ezrak...@gmail.com>
Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
---
  audio/ossaudio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index c43faeeea4aa..94564916fbf0 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@ -420,7 +420,7 @@ static size_t oss_write(HWVoiceOut *hw, void *buf, size_t 
len)
              size_t to_copy = MIN(len, hw->size_emul - hw->pos_emul);
              memcpy(hw->buf_emul + hw->pos_emul, buf, to_copy);

- hw->pos_emul = (hw->pos_emul + to_copy) % hw->pos_emul;

+            hw->pos_emul = (hw->pos_emul + to_copy) % hw->size_emul;

Interestingly oss_put_buffer_out() is correct.

Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>

              buf += to_copy;
              len -= to_copy;
          }