On Thu, Jan 23, 2020 at 12:37:36PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and using MachineState::ram instead of manually initializing > RAM memory region. > > PS: > remove no longer needed DigicBoardState > > PS2: > while at it add check for user supplied RAM size and error > out if it mismatches board expected value. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > --- > v3: > * move 'DigicState *s' declaration to the top of digic4_board_init() > v2: > * fix format string causing build failure on 32-bit host > (Philippe Mathieu-Daudé <phi...@redhat.com>) > > CC: drjo...@redhat.com > CC: antonynpav...@gmail.com > CC: peter.mayd...@linaro.org > CC: qemu-...@nongnu.org > --- > hw/arm/digic_boards.c | 40 +++++++++++++++++++++------------------- > 1 file changed, 21 insertions(+), 19 deletions(-) >
I don't know anything about digic_boards, but I promised Igor to put another pair of eyes on his changes. Looks fine to me. Reviewed-by: Andrew Jones <drjo...@redhat.com>
