On Wed, 2019-11-27 at 08:50 +0100, Markus Armbruster wrote:
> Maxim Levitsky <mlevi...@redhat.com> writes:
>
> > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com>
> > ---
> > blockdev-hmp-cmds.c | 97 ++++++++++++++++++++++++++++++++++++++++++++-
> > blockdev.c | 95 --------------------------------------------
> > 2 files changed, 96 insertions(+), 96 deletions(-)
>
> hmp_drive_add() and hmp_drive_del() are now in the same .c, which feels
> right. Their declarations are still in separate .h. Suggest to move
> hmp_drive_add() from sysemu/sysemu.h to sysemu/blockdev.h. Or maybe
> create a separate .h for the block HMP stuff, just like you created a
> separate .c.
>
>
Agree, I totally forgot about the headers.
I added include/block/blockdev-hmp-cmds.h for that now.
Best regards,
Maxim Levitsky
