Re: [PATCH v5 20/60] target/riscv: vector single-width integer multiply-add instructions

[Richard Henderson]

On 3/12/20 7:58 AM, LIU Zhiwei wrote:
> +#define OPIVX3(NAME, TD, T1, T2, TX1, TX2, HD, HS2, OP)         \
> +static void do_##NAME(void *vd, target_ulong s1, void *vs2, int i)  \
> +{                                                                   \
> +    TX2 s2 = *((T2 *)vs2 + HS2(i));                                 \
> +    TD d = *((TD *)vd + HD(i));                                     \
> +    *((TD *)vd + HD(i)) = OP(s2, (TX1)(T1)(target_long)s1, d);      \
> +}

Change the type of s1?  Otherwise,

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~