Le 24/03/2020 à 09:22, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
> size = 4;
> ^ ~
>
> Reported-by: Euler Robot <euler.ro...@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
> ---
> Cc: Paolo Bonzini <pbonz...@redhat.com>
> Cc:Fam Zheng <f...@euphon.net>
> v1->v2:
> keep ' size = 4' and add 'g_assert(size >= 4)' after if() statement.
> (Base on Laurent's comments)
> ---
> hw/scsi/esp-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
> index d5a1f9e017..497a8d5901 100644
> --- a/hw/scsi/esp-pci.c
> +++ b/hw/scsi/esp-pci.c
> @@ -197,6 +197,7 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
> addr &= ~3;
> size = 4;
> }
> + g_assert(size >= 4);
>
> if (addr < 0x40) {
> /* SCSI core reg */
>
Reviewed-by: Laurent Vivier <laur...@vivier.eu>
