>-----Original Message----- >From: Laurent Vivier [mailto:laur...@vivier.eu] >Sent: Wednesday, March 25, 2020 5:45 PM >To: Chenqun (kuhn) <kuhn.chen...@huawei.com>; qemu-devel@nongnu.org; >qemu-triv...@nongnu.org >Cc: Zhanghailiang <zhang.zhanghaili...@huawei.com>; Euler Robot ><euler.ro...@huawei.com>; Daniel P. Berrangé <berra...@redhat.com> >Subject: Re: [PATCH 3/3] crypto: Redundant type conversion for AES_KEY pointer > >Le 25/03/2020 à 10:21, Chen Qun a écrit : >> Fix: eaec903c5b8 >> > >Did you run the coccinelle script scripts/coccinelle/typecast.cocci ? > Yes, I run it and plan to integrate it into EulerRobot so that similar issues can be discovered sooner.
Thanks. > >> Reported-by: Euler Robot <euler.ro...@huawei.com> >> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> >> --- >> Cc: "Daniel P. Berrangé" <berra...@redhat.com> >> --- >> crypto/cipher-builtin.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index >> bf8413e71a..99d6280a16 100644 >> --- a/crypto/cipher-builtin.c >> +++ b/crypto/cipher-builtin.c >> @@ -133,8 +133,7 @@ static void qcrypto_cipher_aes_xts_encrypt(const >> void *ctx, { >> const QCryptoCipherBuiltinAESContext *aesctx = ctx; >> >> - qcrypto_cipher_aes_ecb_encrypt((AES_KEY *)&aesctx->enc, >> - src, dst, length); >> + qcrypto_cipher_aes_ecb_encrypt(&aesctx->enc, src, dst, length); >> } >> >> >> @@ -145,8 +144,7 @@ static void qcrypto_cipher_aes_xts_decrypt(const >> void *ctx, { >> const QCryptoCipherBuiltinAESContext *aesctx = ctx; >> >> - qcrypto_cipher_aes_ecb_decrypt((AES_KEY *)&aesctx->dec, >> - src, dst, length); >> + qcrypto_cipher_aes_ecb_decrypt(&aesctx->dec, src, dst, length); >> } >> >> >>