On Wed, Mar 25, 2020 at 05:21:35PM +0800, Chen Qun wrote: > According to the glib function requirements, we need initialise > the variable. Otherwise there will be compilation warnings: > > qemu/gdbstub.c: In function ‘handle_query_thread_extra’: > /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: warning: > ‘cpu_name’ may be used uninitialized in this function [-Wmaybe-uninitialized] > g_free (*pp); > ^~~~~~~~~~~~ > > Reported-by: Euler Robot <euler.ro...@huawei.com> > Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> > --- > Cc: "Alex Bennée" <alex.ben...@linaro.org> > Cc: "Philippe Mathieu-Daudé" <phi...@redhat.com> > --- > gdbstub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 013fb1ac0f..171e150950 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -2060,8 +2060,8 @@ static void handle_query_thread_extra(GdbCmdContext > *gdb_ctx, void *user_ctx) > /* Print the CPU model and name in multiprocess mode */ > ObjectClass *oc = object_get_class(OBJECT(cpu)); > const char *cpu_model = object_class_get_name(oc); > - g_autofree char *cpu_name; > - cpu_name = object_get_canonical_path_component(OBJECT(cpu)); > + g_autofree char *cpu_name = > + object_get_canonical_path_component(OBJECT(cpu)); > g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name, > cpu->halted ? "halted " : "running"); > } else { > -- > 2.23.0 > > >
Fixing broken build with -Wall. Reviewed-by: Miroslav Rezanina <mreza...@redhat.com>