On Tue, 24 Mar 2020 at 17:49, Marc-André Lureau <marcandre.lur...@redhat.com> wrote: > > Hi > > On Tue, Mar 24, 2020 at 6:36 PM Peter Maydell <peter.mayd...@linaro.org> > wrote: > > > > In write_elf_section() we set the 'shdr' pointer to point to local > > structures shdr32 or shdr64, which we fill in to be written out to > > the ELF dump. Unfortunately the address we pass to fd_write_vmcore() > > has a spurious '&' operator, so instead of writing out the section > > header we write out the literal pointer value followed by whatever is > > on the stack after the 'shdr' local variable. > > > > Pass the correct address into fd_write_vmcore(). > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
Thanks for the review; since nobody else has picked the patch up I'll put it in via target-arm.next just for convenience. -- PMM
