On Fri, 3 Apr 2020 at 21:55, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > On 3/24/20 6:36 PM, Peter Maydell wrote: > > In write_elf_section() we set the 'shdr' pointer to point to local > > structures shdr32 or shdr64, which we fill in to be written out to > > the ELF dump. Unfortunately the address we pass to fd_write_vmcore() > > has a spurious '&' operator, so instead of writing out the section > > header we write out the literal pointer value followed by whatever is > > on the stack after the 'shdr' local variable. > > How did you notice this? While reviewing around?
Coverity, but I forgot to quote the CID in the commit message. -- PMM
