On 5/19/20 7:11 PM, Stefan Hajnoczi wrote:
> nvme_process_completion() explicitly checks cid so the assertion that
> follows is always true:
>
> if (cid == 0 || cid > NVME_QUEUE_SIZE) {
> ...
> continue;
> }
> assert(cid <= NVME_QUEUE_SIZE);
>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
> block/nvme.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index 7eb4512666..5286227074 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -336,7 +336,6 @@ static bool nvme_process_completion(BDRVNVMeState *s,
> NVMeQueuePair *q)
> cid);
> continue;
> }
> - assert(cid <= NVME_QUEUE_SIZE);
> trace_nvme_complete_command(s, q->index, cid);
> preq = &q->reqs[cid - 1];
> req = *preq;
>
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
