On 5/19/20 7:11 PM, Stefan Hajnoczi wrote:
> Existing users access free_req_queue under q->lock. Document this.
>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
> block/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index 3ad4f27e1c..e32bff26ff 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -57,7 +57,6 @@ typedef struct {
> } NVMeRequest;
>
> typedef struct {
> - CoQueue free_req_queue;
> QemuMutex lock;
>
> /* Fields protected by BQL */
> @@ -65,6 +64,7 @@ typedef struct {
> uint8_t *prp_list_pages;
>
> /* Fields protected by @lock */
> + CoQueue free_req_queue;
> NVMeQueue sq, cq;
> int cq_phase;
> int free_req_head;
>
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
