On 6/5/20 4:56 PM, Markus Armbruster wrote: > qdev_prop_set_drive() can fail. None of the other qdev_prop_set_FOO() > can; they abort on error. > > To clean up this inconsistency, rename qdev_prop_set_drive() to > qdev_prop_set_drive_err(), and create a qdev_prop_set_drive() that > aborts on error. > > Coccinelle script to update callers: > > @ depends on !(file in "hw/core/qdev-properties-system.c")@ > expression dev, name, value; > symbol error_abort; > @@ > - qdev_prop_set_drive(dev, name, value, &error_abort); > + qdev_prop_set_drive(dev, name, value);
Why not open-code qdev_prop_set_drive_err(..., &error_abort)? > > @@ > expression dev, name, value, errp; > @@ > - qdev_prop_set_drive(dev, name, value, errp); > + qdev_prop_set_drive_err(dev, name, value, errp); > [...]
