On 6/10/20 5:51 AM, Thomas Huth wrote:
> The #ifdef CONFIG_VFIO_IGD in pci-quirks.c is not working since the
> required header config-devices.h is not included, so that the legacy
> IGD passthrough is currently broken. Let's include the right header
> to fix this issue.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1882784
> Fixes: 29d62771c81d8fd244a67c14a1d968c268d3fb19
> ("hw/vfio: Move the IGD quirk code to a separate file")
What about shorter tag?
Fixes: 29d62771c81 ("vfio: Move the IGD quirk code to a separate file")
> Signed-off-by: Thomas Huth <th...@redhat.com>
> ---
> hw/vfio/pci-quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> index f2155ddb1d..3158390db1 100644
> --- a/hw/vfio/pci-quirks.c
> +++ b/hw/vfio/pci-quirks.c
> @@ -11,6 +11,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "config-devices.h"
I've been wondering how we can avoid that mistake in the
future, but can find anything beside human review.
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> #include "exec/memop.h"
> #include "qemu/units.h"
> #include "qemu/error-report.h"
>
