On 10/06/2020 15.16, Laurent Vivier wrote: > Le 10/06/2020 à 09:50, Thomas Huth a écrit : >> On 10/06/2020 09.31, Philippe Mathieu-Daudé wrote: >>> On 6/10/20 5:51 AM, Thomas Huth wrote: >>>> The #ifdef CONFIG_VFIO_IGD in pci-quirks.c is not working since the >>>> required header config-devices.h is not included, so that the legacy >>>> IGD passthrough is currently broken. Let's include the right header >>>> to fix this issue. >>>> >>>> Buglink: https://bugs.launchpad.net/qemu/+bug/1882784 >>>> Fixes: 29d62771c81d8fd244a67c14a1d968c268d3fb19 >>>> ("hw/vfio: Move the IGD quirk code to a separate file") >>> >>> What about shorter tag? >>> >>> Fixes: 29d62771c81 ("vfio: Move the IGD quirk code to a separate file") >> >> I always forget whether to use the short or the long version for >> "Fixes:" ... this can hopefully be fixed (if necessary) when the patch >> gets picked up. > > you can add in your ~/.gitconfig > > [alias] > showfix = log -1 --format=fixes > [pretty] > fixes = Fixes: %h (\"%s\")%nCc: %ae > > and then: > > $ git showfix 29d62771c81d8fd244a67c14a1d968c268d3fb19 > Fixes: 29d62771c81d ("hw/vfio: Move the IGD quirk code to a separate file")
That's nice, thanks! I've put it now in my gitconfig :-) Thomas
