Hi Stefan, On 6/15/20 7:11 PM, Stefan Berger wrote: > On 6/15/20 11:13 AM, Marc-André Lureau wrote: >> >>> diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h >>> index 1a2a57a21f..063a9eb42a 100644 >>> --- a/include/hw/acpi/tpm.h >>> +++ b/include/hw/acpi/tpm.h >>> @@ -24,7 +24,7 @@ >>> #define TPM_TIS_ADDR_BASE 0xFED40000 >>> #define TPM_TIS_ADDR_SIZE 0x5000 >>> >>> -#define TPM_TIS_IRQ 5 >>> +#define TPM_TIS_IRQ 13 > > > Eric, > > does this change have any negative side effects on ARM? If you prefer, > we can split this part here up into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS > IRQ and leave the latter at '5' because we know that this is working.
I just gave it a try and it does not seem to introduce any regression with automatic LUKS decryption. I will take more time to review the code though. Thanks Eric > > Stefan > > >>> >>> #define TPM_TIS_NUM_LOCALITIES 5 /* per spec */ >>> #define TPM_TIS_LOCALITY_SHIFT 12 >>> -- >>> 2.24.1 >>> > >
