Laurent Vivier <lviv...@redhat.com> wrote: > multifd_send_pages() loops around the available channels, > the next channel to use between two calls to multifd_send_pages() is stored > inside a local static variable, next_channel. > > It works well, except if the number of channels decreases between two calls > to multifd_send_pages(). In this case, the loop can try to access the > data of a channel that doesn't exist anymore. > > The problem can be triggered if we start a migration with a given number of > channels and then we cancel the migration to restart it with a lower number. > This ends generally with an error like: > qemu-system-ppc64: .../util/qemu-thread-posix.c:77: qemu_mutex_lock_impl: > Assertion `mutex->initialized' failed. > > This patch fixes the error by capping next_channel with the current number > of channels before using it. > > Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Juan Quintela <quint...@redhat.com>