On Fri, Jun 19, 2020 at 06:29:24PM +0200, Lukas Straub wrote: > On Wed, 17 Jun 2020 16:12:40 +0100 > Stefan Hajnoczi <stefa...@gmail.com> wrote: > > > On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote: > > > +static struct YankInstance *yank_find_instance(char *name) > > > > There are const char * -> char * casts in later patches. Please use > > const char * where possible. Callers shouldn't need to cast away const. > > nbd and chardev generate the instance name dynamically so it > needs to be char *, but in migration it's hardcoded.
I think you're looking at it from the wrong perspective. The yank_find_instance() method never modifies the 'name' paramater that it receives. Therefore it should be "const char *". Likewise for the other yank_*() methods in fact. The caller can have a char *, or a const char * as suits its needs. Either can be passed into the yank_* methods and will gain const-ness from the POV of yank code. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
