Daniel P. Berrangé <berra...@redhat.com> writes:
> On Mon, Jun 22, 2020 at 07:26:39PM +0100, Alex Bennée wrote: >> >> Daniel P. Berrangé <berra...@redhat.com> writes: >> >> > We have a number of container images in tests/docker/dockerfiles >> > that are intended to provide well defined environments for doing >> > test builds. We want our CI system to use these containers too. >> > >> > This introduces builds of all of them as the first stage in the >> > CI, so that the built containers are available for later build >> > jobs. The containers are setup to use the GitLab container >> > registry as the cache, so we only pay the penalty of the full >> > build when the dockerfiles change. The main qemu-project/qemu >> > repo is used as a second cache, so that users forking QEMU will >> > see a fast turnaround time on their CI jobs. >> > >> > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> >> > --- >> > .gitlab-ci.d/containers.yml | 248 ++++++++++++++++++++++++++++++++++++ >> > .gitlab-ci.yml | 3 + >> > 2 files changed, 251 insertions(+) >> > create mode 100644 .gitlab-ci.d/containers.yml >> > >> > diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml >> > new file mode 100644 >> > index 0000000000..ea1edbb196 >> > --- /dev/null >> > +++ b/.gitlab-ci.d/containers.yml >> > @@ -0,0 +1,248 @@ >> > + >> > + >> > +.container_job_template: &container_job_definition >> > + image: docker:stable >> > + stage: containers >> > + services: >> > + - docker:dind >> > + before_script: >> > + - export TAG="$CI_REGISTRY_IMAGE/ci-$NAME:latest" >> > + - export >> > COMMON_TAG="$CI_REGISTRY/qemu-project/qemu/ci-$NAME:latest" >> >> It would be nice if we could keep the same form as they have in the >> local registry which would make it easier to integrate with the rest of >> the tooling, e.g. "$CI_REGISTRY/qemu-project/qemu:$NAME" > > Every time I re-discover it, I find the QEMU container naming really > surprising. It is not following the normal best practice for naming > containers. Expected container naming convention is that the image > name reflects the general content set, and the tag reflects a version > number. QEMU has shifted it along, so container name is just a fixed > string, and the tag reflects the contenet set, and there is no version. > > QEMU's naming will cause problems with caching in GitLab. As GitLab > expects the normal container naming scheme, it has a job which expires > old versions of an image once there are more than 10 tags. So we have > to use the normal naming scheme. Ideally we would change rest of QEMU > to use the normal scheme too. Fair enough.. I'll look into it. > > Regards, > Daniel -- Alex Bennée