On 25/06/20 17:02, Roman Bolshakov wrote: > macvm_set_cr0() sets/clears LMA in entry controls only in case of > transitions into/out of long mode in enter_long_mode() in > exit_long_mode(), respectively. But macvm_set_cr0() doesn't load > EFER.LMA from CPUX86State into VMCS entry controls during reset and > that's where hvf_put_registers() might not behave properly. > > As far as I understand you propose to drop explicit LMA reset in > post-reset and rather impove synchronization between efer and entry > controls in macvm_set_cr0(), right? In that case I don't see a > regression in the series, and if possible I'd prefer a follow up patch > for the issue.
Indeed it's not a regression. Thanks! Paolo
