On 29/06/20 13:55, P J P wrote: > | > | I prefer here just 'qemu_log_mask(LOG_UNIMP, "%s not implemented\n", > | __func__);' as other patches does. > > Earlier patch v1 did that. It was suggested to return ldl_le_p(), as that's a > valid return IIUC, instead of a zero(0), in case flash_read() is called. > > Thanks so much for the reviews. I'll send a revised series with due updates.
I think abort() is preferable (while LOG_UNIMP is wrong as it implies there is something to do that QEMU is not doing). Paolo
