On 6/29/20 4:48 PM, David CARLIER wrote:
From 5c6022f21289eb6e78e93d584c766db82165dced Mon Sep 17 00:00:00 2001
From: David Carlier <devne...@gmail.com>
Date: Mon, 29 Jun 2020 22:13:35 +0000
Subject: [PATCH 1/9] Enabling BSD symbols.

Suggestion for the title:

build: Enable BSD symbols for Haiku

Rationale for that suggestion: most commits start with a category (here, 'build:' is a nice catch-all, since you are improving the build for a given platform). We tend to avoid trailing '.' in the subject. And mentioning which platform is affected is useful for someone browsing one-line summaries to know the scope of theh change.

Also, this message (and the rest of the series) came through as a top-level thread, rather than in-reply-to the 0/9 message. That makes it harder to track the changes as a group.


Signed-off-by: David Carlier <devne...@gmail.com>
---
  configure | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 4a22dcd563..d81931ba5e 100755
--- a/configure
+++ b/configure
@@ -903,8 +903,8 @@ SunOS)
  ;;
  Haiku)
    haiku="yes"
-  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS $QEMU_CFLAGS"
-  LIBS="-lposix_error_mapper -lnetwork $LIBS"
+  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -DBSD_SOURCE $QEMU_CFLAGS"
+  LIBS="-lposix_error_mapper -lnetwork -lbsd $LIBS"
  ;;
  Linux)
    audio_drv_list="try-pa oss"
--
2.26.0


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


Reply via email to