Hi Peter, On 7/5/20 8:21 PM, Peter Maydell wrote: > On Fri, 3 Jul 2020 at 17:54, Peter Maydell <peter.mayd...@linaro.org> wrote: >> >> From: Eric Auger <eric.au...@redhat.com> >> >> This patch implements the PROBE request. At the moment, >> only THE RESV_MEM property is handled. The first goal is >> to report iommu wide reserved regions such as the MSI regions >> set by the machine code. On x86 this will be the IOAPIC MSI >> region, [0xFEE00000 - 0xFEEFFFFF], on ARM this may be the ITS >> doorbell. > >> @@ -452,6 +524,17 @@ static void virtio_iommu_handle_command(VirtIODevice >> *vdev, VirtQueue *vq) >> case VIRTIO_IOMMU_T_UNMAP: >> tail.status = virtio_iommu_handle_unmap(s, iov, iov_cnt); >> break; >> + case VIRTIO_IOMMU_T_PROBE: >> + { >> + struct virtio_iommu_req_tail *ptail; >> + >> + output_size = s->config.probe_size + sizeof(tail); >> + buf = g_malloc0(output_size); >> + >> + ptail = (struct virtio_iommu_req_tail *) >> + (buf + s->config.probe_size); >> + ptail->status = virtio_iommu_handle_probe(s, iov, iov_cnt, buf); >> + } >> default: >> tail.status = VIRTIO_IOMMU_S_UNSUPP; >> } > > Hi Eric -- Coverity points out (CID 1430180) that this new case > has neither a 'break' nor a /* fallthrough */ comment. Which is correct? Thank you for reporting. Sure I will send a fix. This is harmless from a functional pov.
Best Regards Eric > > thanks > -- PMM >