On 27/07/2020 12.57, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 05:50:47PM +0100, Peter Maydell wrote: >> On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé <phi...@redhat.com> >> wrote: >>> I guess we were expecting the distrib to update the pkg. >> >> Apple's view is that you shouldn't be using the sasl header >> at all but instead their proprietary crypto library APIs, so >> I wouldn't expect them to ever ship something without the >> deprecation warnings. > > So from pov of our CI, it seems the right answer is to modify the > cirrus.yml to install libsasl2 from homebrew: > > https://formulae.brew.sh/formula-linux/libsasl2
Ok, that one confused me for quite a while, since brew refused to find it in the macOS jobs on Cirrus-CI. The solution: This is not a macOS package, but a Linux package! Homebrew is apparently also available for Linux. There is no libsasl package in homebrew for macOS. So what to do now? I think introducing a libsasl submodule to QEMU just for compiling this code on macOS without warnings is also overkill. And if I got the answers here right, --disable-sasl is also disliked (since this code likely should still be (compile-)tested on macOS). So I think I'll go for the same trick as Peter is using for his tests and use --extra-cflags='-Werror -Wno-error=deprecated-declarations'. Thomas
