On Fri, Jul 31, 2020 at 5:24 AM Richard Henderson < richard.hender...@linaro.org> wrote:
> On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > > From: Frank Chang <frank.ch...@sifive.com> > > > > Sign-extend vsaddu.vi immediate value. > > > > Signed-off-by: Frank Chang <frank.ch...@sifive.com> > > --- > > target/riscv/insn_trans/trans_rvv.inc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/riscv/insn_trans/trans_rvv.inc.c > b/target/riscv/insn_trans/trans_rvv.inc.c > > index 956ee90745..3018489536 100644 > > --- a/target/riscv/insn_trans/trans_rvv.inc.c > > +++ b/target/riscv/insn_trans/trans_rvv.inc.c > > @@ -2374,7 +2374,7 @@ GEN_OPIVX_TRANS(vsaddu_vx, opivx_check) > > GEN_OPIVX_TRANS(vsadd_vx, opivx_check) > > GEN_OPIVX_TRANS(vssubu_vx, opivx_check) > > GEN_OPIVX_TRANS(vssub_vx, opivx_check) > > -GEN_OPIVI_TRANS(vsaddu_vi, IMM_ZX, vsaddu_vx, opivx_check) > > +GEN_OPIVI_TRANS(vsaddu_vi, IMM_SX, vsaddu_vx, opivx_check) > > GEN_OPIVI_TRANS(vsadd_vi, IMM_SX, vsadd_vx, opivx_check) > > > > /* Vector Single-Width Averaging Add and Subtract */ > > > > This isn't what spike does. > > The manual could really stand to be more specific here... > > > r~ > Isn't Spike's vsaddu.vi immediate value also signed-extended? *riscv/insns/vsaddu_vi.h:* *vd = vs2 + (insn.v_simm5() & (UINT64_MAX >> (64 - P.VU.vsew))); * >From RVV 0.9 spec.: *vsaddu.vi <http://vsaddu.vi> vd, vs2, imm, vm # vector-immediate* It also mentions *imm* is sign-extended. In contrast, *uimm* represents the immediate value to be zero-extended. Frank Chang
