On 8/3/20 4:18 AM, Peter Maydell wrote: > At the moment we check for XScale/iwMMXt insns inside > disas_coproc_insn(): for CPUs with ARM_FEATURE_XSCALE all copro insns > with cp 0 or 1 are handled specially. This works, but is an odd > place for this check, because disas_coproc_insn() is called from both > the Arm and Thumb decoders but the XScale case never applies for > Thumb (all the XScale CPUs were ARMv5, which has only Thumb1, not > Thumb2 with the 32-bit coprocessor insn encodings). It also makes it > awkward to convert the real copro access insns to decodetree. > > Move the identification of XScale out to its own function > which is only called from disas_arm_insn(). > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > target/arm/translate.c | 44 ++++++++++++++++++++++++++++-------------- > 1 file changed, 29 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
