On 07/08/20 08:53, Cornelia Huck wrote: > So, I was planning to give it a go on s390, but I cannot even build it > on x86 (fails configure): > > Build started at 2020-08-07T08:43:43.873638 > Main binary: /usr/bin/python3 > Build Options: -Doptimization=2 -Ddebug=true -Dwerror=true -Dstrip=true > -Db_pie=true -Db_coverage=false -Dsdl=auto -Dsdl_image=auto -Dvnc=enabled > -Dvnc_sasl=auto -Dvnc_jpeg=auto -Dvnc_png=auto -Dprefix=/usr/local > -Dbindir=/usr/local/bin -Ddatadir=/usr/local/share > -Dincludedir=/usr/local/include -Dlibdir=/usr/local/lib > -Dlibexecdir=/usr/local/libexec -Dlocalstatedir=/usr/local/var > -Dmandir=/usr/local/share/man -Dsysconfdir=/usr/local/etc > Python system: Linux > The Meson build system > Version: 0.52.0 > Source dir: /home/cohuck/git/qemu > Build dir: /home/cohuck/git/qemu/build > Build type: native build > > meson.build:438:22: ERROR: Key must be a string. > config_target_h += {target: configure_file(output: target + > '-config-target.h', > ^ > (Fedora 31, version from your github branch) > > Is there anything special I need to install beyond meson?
You probably need to do "git submodule init"/"git submodule update" so that it picks up the in-tree meson (0.55.0). If you want to test on s390, just testing the boot ROM would be great (patch 3). That one does not need Meson at all; the purpose of the patch is just to decouple the boot ROM makefile from rules.mak, which allows to drop some of the contents of rules.mak. Paolo