From: Volker RĂ¼melin <vr_q...@t-online.de> This patch removes unnecessary calls to the pcm_ops function put_buffer_in(). No audio backend needs this call if the returned length of pcm_ops function get_buffer_in() is zero.
For the DirectSound backend this prevents a call to dsound_unlock_in() without a preceding call to dsound_lock_in(). While Windows doesn't complain it seems wrong anyway. Signed-off-by: Volker RĂ¼melin <vr_q...@t-online.de> Message-id: 20200920171729.15861-5-vr_q...@t-online.de Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- audio/audio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 5c47a036028c..341edc4d0012 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1261,7 +1261,6 @@ static size_t audio_pcm_hw_run_in(HWVoiceIn *hw, size_t samples) assert(size % hw->info.bytes_per_frame == 0); if (size == 0) { - hw->pcm_ops->put_buffer_in(hw, buf, size); break; } @@ -1502,7 +1501,6 @@ size_t audio_generic_read(HWVoiceIn *hw, void *buf, size_t size) void *src = hw->pcm_ops->get_buffer_in(hw, &src_size); if (src_size == 0) { - hw->pcm_ops->put_buffer_in(hw, src, src_size); break; } -- 2.27.0